That exact chain of events happened to me at my last job and I audibly laughed realising it was my own code. To my own credit though, it was a file I had written four years prior which at that point was more than half my whole career in the past
I have lately jokingly guessed when I see the particular style and confusion: it’s you isn’t it? And so far I have been right. The particular author’s magic as expired, and I see the same fault replicated everywhere he has been.
UUUuuuuuh, I am not a programmer (you’re going to say “thank god”), but…
I sometimes even chain them. You can put yet another ternary operator in the else and keep going. You know, else-if.
So anyway, I can get ternary operators spanning 2 - 3 lines.
Oh, I also often have issues thinking of proper loops, so you’d see a few terribly used goto statements.
Although I do remove ones that are obvious brain fart.
For example, quite obvious
voidexample(bool true_or_false){
if(true_or_false){
//code if true
}
else{
//code if false
}
//other code
}
Well, I’ve already had my brain goof up even that once or twice. “How the fuck”, you’re asking?
voidexample(bool true_or_false){
if(true_or_false){
goto if_true;
}
//code if falsegoto end_false_if;
if_true:
//code if true
end_false_if:
//other code
}
git blameOh
I love that they called it “blame” lol. They knew what it would be used for.
Subversion tried to call it “annotate”, but that didn’t stick ;)
Not sure if was there from the beginning but it was originally developed by Linus Torvalds and he can be quite harsh to the Linux contributors.
Isn’t it alias for git praise?
That exact chain of events happened to me at my last job and I audibly laughed realising it was my own code. To my own credit though, it was a file I had written four years prior which at that point was more than half my whole career in the past
If you aren’t ashamed of your work a year ago, you’re stagnating!
These days I see so much AI slop that my reaction when I see code I hand-wrote myself is “hey, that’s pretty good”.
My team’s code is great, but we use a lot of shared code written by other teams, with varying levels of quality.
Been writing the same software for 20+ years now, don’t even need git blame to figure out what asshole wrote this shit.
Why is it always me? Haha
Yup there are certain patterns that I can just tell
Sometimes you don’t even recognize your own trash, 6 weeks later.
I have lately jokingly guessed when I see the particular style and confusion: it’s you isn’t it? And so far I have been right. The particular author’s magic as expired, and I see the same fault replicated everywhere he has been.
One of my coworkers is fond of using ternary expressions instead of “if” blocks. Even ones without an “else”. So I see things like:
condition ? someVar = "blah" : null;or
condition ? doSomething() : nullWhich should both just use “if” statements. Or my favorite:
condition ? someVar = "foo" : someVar = "bar"which should really be
someVar = condition ? "foo" : "bar"UUUuuuuuh, I am not a programmer (you’re going to say “thank god”), but…
I sometimes even chain them. You can put yet another ternary operator in the else and keep going. You know, else-if.
So anyway, I can get ternary operators spanning 2 - 3 lines.
Oh, I also often have issues thinking of proper loops, so you’d see a few terribly used
gotostatements.Although I do remove ones that are obvious brain fart.
For example, quite obvious
void example(bool true_or_false){ if(true_or_false){ //code if true } else{ //code if false } //other code }Well, I’ve already had my brain goof up even that once or twice. “How the fuck”, you’re asking?
void example(bool true_or_false){ if(true_or_false){ goto if_true; } //code if false goto end_false_if; if_true: //code if true end_false_if: //other code }The brain-fart if-else.
The last thing, that would be a “request changes” for me.
I haven’t seen him do it lately in any code I’ve reviewed but I do change it whenever I see it if I’m doing work nearby lol
I mean, admitting you have a problem is the first step to a solution…
Oh, man. Can you tell what the second step is? I’d really like to learn that.
Working to fix it… (which of course varies wildly based on the problem!)
Not if the author was your boss.